Skip to content

Commit 34be68c

Browse files
rafaeljwgregkh
authored andcommitted
platform/surface: surfacepro3_button: Drop wakeup source on remove
[ Upstream commit 1410a22 ] The wakeup source added by device_init_wakeup() in surface_button_add() needs to be dropped during driver removal, so update the driver to do that. Fixes: 19351f3 ("platform/x86: surfacepro3: Support for wakeup from suspend-to-idle") Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com> Link: https://patch.msgid.link/4368848.1IzOArtZ34@rafael.j.wysocki Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com> Signed-off-by: Sasha Levin <sashal@kernel.org>
1 parent 834dece commit 34be68c

1 file changed

Lines changed: 1 addition & 0 deletions

File tree

drivers/platform/surface/surfacepro3_button.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -243,6 +243,7 @@ static void surface_button_remove(struct acpi_device *device)
243243
{
244244
struct surface_button *button = acpi_driver_data(device);
245245

246+
device_init_wakeup(&device->dev, false);
246247
input_unregister_device(button->input);
247248
kfree(button);
248249
}

0 commit comments

Comments
 (0)