Skip to content

Commit 3828391

Browse files
outman119gregkh
authored andcommitted
pinctrl: microchip-mssio: Fix missing return in probe
[ Upstream commit 8f72335 ] In mpfs_pinctrl_probe(), when pctrl->regmap fails, it just print out an error message without return, which could lead serious errors. Fixes: 488d704 ("pinctrl: add polarfire soc mssio pinctrl driver") Signed-off-by: Felix Gu <ustc.gu@gmail.com> Reviewed-by: Conor Dooley <conor.dooley@microchip.com> Signed-off-by: Linus Walleij <linusw@kernel.org> Signed-off-by: Sasha Levin <sashal@kernel.org>
1 parent 7a1d6ed commit 3828391

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

drivers/pinctrl/microchip/pinctrl-mpfs-mssio.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -686,7 +686,7 @@ static int mpfs_pinctrl_probe(struct platform_device *pdev)
686686

687687
pctrl->regmap = device_node_to_regmap(pdev->dev.parent->of_node);
688688
if (IS_ERR(pctrl->regmap))
689-
dev_err_probe(dev, PTR_ERR(pctrl->regmap), "Failed to find syscon regmap\n");
689+
return dev_err_probe(dev, PTR_ERR(pctrl->regmap), "Failed to find syscon regmap\n");
690690

691691
pctrl->sysreg_regmap = syscon_regmap_lookup_by_compatible("microchip,mpfs-sysreg-scb");
692692
if (IS_ERR(pctrl->sysreg_regmap))

0 commit comments

Comments
 (0)