Skip to content

Commit 3a8d944

Browse files
alexdadu-imgtecgregkh
authored andcommitted
drm/imagination: Switch reset_reason fields from enum to u32
[ Upstream commit d2f83a6 ] Update the reset_reason fwif structure fields from enum to u32 to remove any ambiguity from the interface (enum is not a fixed size thus is unfit for the purpose of the data type). Fixes: a26f067 ("drm/imagination: Add FWIF headers") Signed-off-by: Alexandru Dadu <alexandru.dadu@imgtec.com> Reviewed-by: Matt Coster <matt.coster@imgtec.com> Link: https://patch.msgid.link/20260323-b4-firmware-context-reset-notification-handling-v3-2-1a66049a9a65@imgtec.com Signed-off-by: Matt Coster <matt.coster@imgtec.com> Signed-off-by: Sasha Levin <sashal@kernel.org>
1 parent 3d0ef05 commit 3a8d944

2 files changed

Lines changed: 11 additions & 3 deletions

File tree

drivers/gpu/drm/imagination/pvr_rogue_fwif.h

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1347,8 +1347,12 @@ struct rogue_fwif_fwccb_cmd_freelists_reconstruction_data {
13471347
struct rogue_fwif_fwccb_cmd_context_reset_data {
13481348
/* Context affected by the reset */
13491349
u32 server_common_context_id;
1350-
/* Reason for reset */
1351-
enum rogue_context_reset_reason reset_reason;
1350+
/*
1351+
* Reason for reset
1352+
* The valid values for reset_reason are the ones from
1353+
* enum rogue_context_reset_reason
1354+
*/
1355+
u32 reset_reason;
13521356
/* Data Master affected by the reset */
13531357
u32 dm;
13541358
/* Job ref running at the time of reset */

drivers/gpu/drm/imagination/pvr_rogue_fwif_shared.h

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -249,7 +249,11 @@ enum rogue_context_reset_reason {
249249
};
250250

251251
struct rogue_context_reset_reason_data {
252-
enum rogue_context_reset_reason reset_reason;
252+
/*
253+
* The valid values for reset_reason are the ones from
254+
* enum rogue_context_reset_reason
255+
*/
256+
u32 reset_reason;
253257
u32 reset_ext_job_ref;
254258
};
255259

0 commit comments

Comments
 (0)