Skip to content

Commit 3de6266

Browse files
keithbuschgregkh
authored andcommitted
nvme-pci: fix missed admin queue sq doorbell write
[ Upstream commit 1cc4cda ] We can batch admin commands submitted through io_uring_cmd passthrough, which means bd->last may be false and skips the doorbell write to aggregate multiple commands per write. If a subsequent command can't be dispatched for whatever reason, we have to provide the blk-mq ops' commit_rqs callback in order to ensure we properly update the doorbell. Fixes: 58e5bde ("nvme: enable uring-passthrough for admin commands") Reviewed-by: Christoph Hellwig <hch@lst.de> Reviewed-by: Kanchan Joshi <joshi.k@samsung.com> Signed-off-by: Keith Busch <kbusch@kernel.org> Signed-off-by: Sasha Levin <sashal@kernel.org>
1 parent 03ea11d commit 3de6266

1 file changed

Lines changed: 1 addition & 0 deletions

File tree

drivers/nvme/host/pci.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1816,6 +1816,7 @@ static int nvme_create_queue(struct nvme_queue *nvmeq, int qid, bool polled)
18161816
static const struct blk_mq_ops nvme_mq_admin_ops = {
18171817
.queue_rq = nvme_queue_rq,
18181818
.complete = nvme_pci_complete_rq,
1819+
.commit_rqs = nvme_commit_rqs,
18191820
.init_hctx = nvme_admin_init_hctx,
18201821
.init_request = nvme_pci_init_request,
18211822
.timeout = nvme_timeout,

0 commit comments

Comments
 (0)