Skip to content

Commit 47b2d7b

Browse files
CFSworksgregkh
authored andcommitted
arm64: dts: rockchip: Remove workaround that prevented Turing RK1 GPU power regulator control
commit de5b39d upstream. The RK3588 GPU power domain cannot be activated unless the external power regulator is already on. When GPU support was added to this DT, we had no way to represent this requirement, so `regulator-always-on` was added to the `vdd_gpu_s0` regulator in order to ensure stability. A later patch series (see "Fixes:" commit) resolved this shortcoming, but that commit left the workaround -- and rendered the comment above it no longer correct. Remove the workaround to allow the GPU power regulator to power off, now that the DT includes the necessary information to power it back on correctly. Fixes: f94500e ("arm64: dts: rockchip: Add GPU power domain regulator dependency for RK3588") Signed-off-by: Sam Edwards <CFSworks@gmail.com> Cc: stable@vger.kernel.org Link: https://lore.kernel.org/r/20250608184855.130206-1-CFSworks@gmail.com Signed-off-by: Heiko Stuebner <heiko@sntech.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent fb62e21 commit 47b2d7b

File tree

1 file changed

+0
-11
lines changed

1 file changed

+0
-11
lines changed

arch/arm64/boot/dts/rockchip/rk3588-turing-rk1.dtsi

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -398,17 +398,6 @@
398398

399399
regulators {
400400
vdd_gpu_s0: vdd_gpu_mem_s0: dcdc-reg1 {
401-
/*
402-
* RK3588's GPU power domain cannot be enabled
403-
* without this regulator active, but it
404-
* doesn't have to be on when the GPU PD is
405-
* disabled. Because the PD binding does not
406-
* currently allow us to express this
407-
* relationship, we have no choice but to do
408-
* this instead:
409-
*/
410-
regulator-always-on;
411-
412401
regulator-boot-on;
413402
regulator-min-microvolt = <550000>;
414403
regulator-max-microvolt = <950000>;

0 commit comments

Comments
 (0)