Skip to content

Commit 480307f

Browse files
geertugregkh
authored andcommitted
lib/hexdump: print_hex_dump_bytes() calls print_hex_dump_debug()
[ Upstream commit 36776b7 ] print_hex_dump_bytes() claims to be a simple wrapper around print_hex_dump(), but it actally calls print_hex_dump_debug(), which means no output is printed if (dynamic) DEBUG is disabled. Update the documentation to match the implementation. Fixes: 091cb09 ("lib/hexdump: make print_hex_dump_bytes() a nop on !DEBUG builds") Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> Reviewed-by: Petr Mladek <pmladek@suse.com> Link: https://patch.msgid.link/3d5c3069fd9102ecaf81d044b750cd613eb72a08.1774970392.git.geert+renesas@glider.be Signed-off-by: Petr Mladek <pmladek@suse.com> Signed-off-by: Sasha Levin <sashal@kernel.org>
1 parent 3547f6b commit 480307f

1 file changed

Lines changed: 3 additions & 2 deletions

File tree

include/linux/printk.h

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -816,15 +816,16 @@ static inline void print_hex_dump_devel(const char *prefix_str, int prefix_type,
816816
#endif
817817

818818
/**
819-
* print_hex_dump_bytes - shorthand form of print_hex_dump() with default params
819+
* print_hex_dump_bytes - shorthand form of print_hex_dump_debug() with default
820+
* params
820821
* @prefix_str: string to prefix each line with;
821822
* caller supplies trailing spaces for alignment if desired
822823
* @prefix_type: controls whether prefix of an offset, address, or none
823824
* is printed (%DUMP_PREFIX_OFFSET, %DUMP_PREFIX_ADDRESS, %DUMP_PREFIX_NONE)
824825
* @buf: data blob to dump
825826
* @len: number of bytes in the @buf
826827
*
827-
* Calls print_hex_dump(), with log level of KERN_DEBUG,
828+
* Calls print_hex_dump_debug(), with log level of KERN_DEBUG,
828829
* rowsize of 16, groupsize of 1, and ASCII output included.
829830
*/
830831
#define print_hex_dump_bytes(prefix_str, prefix_type, buf, len) \

0 commit comments

Comments
 (0)