Skip to content
/ linux Public

Commit 4897bd3

Browse files
tobluxgregkh
authored andcommitted
crash_dump: don't log dm-crypt key bytes in read_key_from_user_keying
commit 36f46b0 upstream. When debug logging is enabled, read_key_from_user_keying() logs the first 8 bytes of the key payload and partially exposes the dm-crypt key. Stop logging any key bytes. Link: https://lkml.kernel.org/r/20260227230008.858641-2-thorsten.blum@linux.dev Fixes: 479e585 ("crash_dump: store dm crypt keys in kdump reserved memory") Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev> Cc: Baoquan He <bhe@redhat.com> Cc: Coiby Xu <coxu@redhat.com> Cc: Dave Young <dyoung@redhat.com> Cc: Vivek Goyal <vgoyal@redhat.com> Cc: <stable@vger.kernel.org> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent a226e5b commit 4897bd3

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

kernel/crash_dump_dm_crypt.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -168,8 +168,8 @@ static int read_key_from_user_keying(struct dm_crypt_key *dm_key)
168168

169169
memcpy(dm_key->data, ukp->data, ukp->datalen);
170170
dm_key->key_size = ukp->datalen;
171-
kexec_dprintk("Get dm crypt key (size=%u) %s: %8ph\n", dm_key->key_size,
172-
dm_key->key_desc, dm_key->data);
171+
kexec_dprintk("Get dm crypt key (size=%u) %s\n", dm_key->key_size,
172+
dm_key->key_desc);
173173

174174
out:
175175
up_read(&key->sem);

0 commit comments

Comments
 (0)