Skip to content

Commit 50b7207

Browse files
vdadhanigregkh
authored andcommitted
serial: qcom_geni: Fix RX DMA stall when SE_DMA_RX_LEN_IN is zero
commit b93062b upstream. In qcom_geni_serial_handle_rx_dma(), geni_se_rx_dma_unprep() clears port->rx_dma_addr before SE_DMA_RX_LEN_IN is read. If the register is zero, for example when the RX stale counter fires on an idle line, the handler returns without calling geni_se_rx_dma_prep(). The next RX DMA interrupt then hits the !port->rx_dma_addr guard and returns immediately, so the RX DMA buffer is never rearmed and later input is lost. Keep the handler on the rearm path when rx_in is zero. Warn about the unexpected zero-length DMA completion, skip received-data handling, and always call geni_se_rx_dma_prep(). Fixes: 2aaa43c ("tty: serial: qcom-geni-serial: add support for serial engine DMA") Cc: stable@vger.kernel.org Reviewed-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com> Signed-off-by: Viken Dadhaniya <viken.dadhaniya@oss.qualcomm.com> Link: https://patch.msgid.link/20260528-serial-rx-0-byte-fix-v2-1-b4195cfe342f@oss.qualcomm.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent 7cc3dd7 commit 50b7207

1 file changed

Lines changed: 3 additions & 6 deletions

File tree

drivers/tty/serial/qcom_geni_serial.c

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -896,12 +896,9 @@ static void qcom_geni_serial_handle_rx_dma(struct uart_port *uport, bool drop)
896896
port->rx_dma_addr = 0;
897897

898898
rx_in = readl(uport->membase + SE_DMA_RX_LEN_IN);
899-
if (!rx_in) {
900-
dev_warn(uport->dev, "serial engine reports 0 RX bytes in!\n");
901-
return;
902-
}
903-
904-
if (!drop)
899+
if (!rx_in)
900+
dev_warn_ratelimited(uport->dev, "serial engine reports 0 RX bytes in!\n");
901+
else if (!drop)
905902
handle_rx_uart(uport, rx_in);
906903

907904
ret = geni_se_rx_dma_prep(&port->se, port->rx_buf,

0 commit comments

Comments
 (0)