media: pci: zoran: fix potential memory leak in zoran_probe()

Abdun Nihaal · gregkh · commit 530a401f1fef · 2026-05-17T17:14:29.000+02:00
commit 8ea2143 upstream. The memory allocated for codec in videocodec_attach() is not freed in one of the error paths, due to an incorrect goto label. Fix the label to free it on error. Fixes: 8f7cc5c ("media: staging: media: zoran: introduce zoran_i2c_init") Cc: stable@vger.kernel.org Signed-off-by: Abdun Nihaal <nihaal@cse.iitm.ac.in> Signed-off-by: Hans Verkuil <hverkuil+cisco@kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
diff --git a/drivers/media/pci/zoran/zoran_card.c b/drivers/media/pci/zoran/zoran_card.c
@@ -1377,7 +1377,7 @@ static int zoran_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
 		}
 		if (zr->codec->type != zr->card.video_codec) {
 			pci_err(pdev, "%s - wrong codec\n", __func__);
-			goto zr_unreg_videocodec;
+			goto zr_detach_codec;
 		}
 	}
 	if (zr->card.video_vfe != 0) {

Original file line number	Diff line number	Diff line change
`@@ -1377,7 +1377,7 @@ static int zoran_probe(struct pci_dev pdev, const struct pci_device_id ent)`
`1377`	`1377`	`}`
`1378`	`1378`	`if (zr->codec->type != zr->card.video_codec) {`
`1379`	`1379`	`pci_err(pdev, "%s - wrong codec\n", __func__);`
`1380`		`- goto zr_unreg_videocodec;`
	`1380`	`+ goto zr_detach_codec;`
`1381`	`1381`	`}`
`1382`	`1382`	`}`
`1383`	`1383`	`if (zr->card.video_vfe != 0) {`