Skip to content
/ linux Public

Commit 56f0473

Browse files
alexdeuchergregkh
authored andcommitted
drm/amdgpu/mmhub3.0.1: add bounds checking for cid
commit 5d4e88b upstream. The value should never exceed the array size as those are the only values the hardware is expected to return, but add checks anyway. Reviewed-by: Benjamin Cheng <benjamin.cheng@amd.com> Signed-off-by: Alex Deucher <alexander.deucher@amd.com> (cherry picked from commit 5f76083183363c4528a4aaa593f5d38c28fe7d7b) Cc: stable@vger.kernel.org Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent 603db8a commit 56f0473

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

drivers/gpu/drm/amd/amdgpu/mmhub_v3_0_1.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -117,7 +117,8 @@ mmhub_v3_0_1_print_l2_protection_fault_status(struct amdgpu_device *adev,
117117

118118
switch (amdgpu_ip_version(adev, MMHUB_HWIP, 0)) {
119119
case IP_VERSION(3, 0, 1):
120-
mmhub_cid = mmhub_client_ids_v3_0_1[cid][rw];
120+
mmhub_cid = cid < ARRAY_SIZE(mmhub_client_ids_v3_0_1) ?
121+
mmhub_client_ids_v3_0_1[cid][rw] : NULL;
121122
break;
122123
default:
123124
mmhub_cid = NULL;

0 commit comments

Comments
 (0)