Skip to content

Commit 5acbbb2

Browse files
coleleavittgregkh
authored andcommitted
soundwire: bus: demote UNATTACHED state warnings to dev_dbg()
[ Upstream commit 2c96956 ] The dev_warn() messages in sdw_handle_slave_status() for UNATTACHED transitions were added in commit d1b3285 ("soundwire: bus: add dev_warn() messages to track UNATTACHED devices") to debug attachment failures with dynamic debug enabled. These warnings fire during normal operation -- for example when a codec driver triggers a hardware reset after firmware download, causing the device to momentarily go UNATTACHED before re-attaching -- producing misleading noise on every boot. Demote the messages to dev_dbg() so they remain available via dynamic debug for diagnosing real attachment failures without alarming users during expected initialization sequences. Fixes: d1b3285 ("soundwire: bus: add dev_warn() messages to track UNATTACHED devices") Signed-off-by: Cole Leavitt <cole@unwrap.rs> Reviewed-by: Richard Fitzgerald <rf@opensource.cirrus.com> Link: https://patch.msgid.link/20260218180210.9263-1-cole@unwrap.rs Signed-off-by: Vinod Koul <vkoul@kernel.org> Signed-off-by: Sasha Levin <sashal@kernel.org>
1 parent faa66f3 commit 5acbbb2

1 file changed

Lines changed: 4 additions & 4 deletions

File tree

drivers/soundwire/bus.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1864,8 +1864,8 @@ int sdw_handle_slave_status(struct sdw_bus *bus,
18641864

18651865
if (status[i] == SDW_SLAVE_UNATTACHED &&
18661866
slave->status != SDW_SLAVE_UNATTACHED) {
1867-
dev_warn(&slave->dev, "Slave %d state check1: UNATTACHED, status was %d\n",
1868-
i, slave->status);
1867+
dev_dbg(&slave->dev, "Slave %d state check1: UNATTACHED, status was %d\n",
1868+
i, slave->status);
18691869
sdw_modify_slave_status(slave, SDW_SLAVE_UNATTACHED);
18701870

18711871
/* Ensure driver knows that peripheral unattached */
@@ -1916,8 +1916,8 @@ int sdw_handle_slave_status(struct sdw_bus *bus,
19161916
if (slave->status == SDW_SLAVE_UNATTACHED)
19171917
break;
19181918

1919-
dev_warn(&slave->dev, "Slave %d state check2: UNATTACHED, status was %d\n",
1920-
i, slave->status);
1919+
dev_dbg(&slave->dev, "Slave %d state check2: UNATTACHED, status was %d\n",
1920+
i, slave->status);
19211921

19221922
sdw_modify_slave_status(slave, SDW_SLAVE_UNATTACHED);
19231923
break;

0 commit comments

Comments
 (0)