Skip to content

Commit 62c4ab1

Browse files
TE-N-ShengjiuWanggregkh
authored andcommitted
ASoC: fsl_micfil: Fix event generation in hwvad_put_enable()
[ Upstream commit 59b9061 ] ALSA controls should return 1 if the value in the control changed but the control put operation hwvad_put_enable() only returns 0 or a negative error code, causing ALSA to not generate any change events. Add a suitable check in the function before updating the vad_enabled variable. Fixes: 29dbfee ("ASoC: fsl_micfil: Add Hardware Voice Activity Detector support") Signed-off-by: Shengjiu Wang <shengjiu.wang@nxp.com> Link: https://patch.msgid.link/20260401094226.2900532-3-shengjiu.wang@nxp.com Signed-off-by: Mark Brown <broonie@kernel.org> Signed-off-by: Sasha Levin <sashal@kernel.org>
1 parent 6adc82f commit 62c4ab1

1 file changed

Lines changed: 6 additions & 1 deletion

File tree

sound/soc/fsl/fsl_micfil.c

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -277,10 +277,15 @@ static int hwvad_put_enable(struct snd_kcontrol *kcontrol,
277277
unsigned int *item = ucontrol->value.enumerated.item;
278278
struct fsl_micfil *micfil = snd_soc_component_get_drvdata(comp);
279279
int val = snd_soc_enum_item_to_val(e, item[0]);
280+
bool change = false;
280281

282+
if (val < 0 || val > 1)
283+
return -EINVAL;
284+
285+
change = (micfil->vad_enabled != val);
281286
micfil->vad_enabled = val;
282287

283-
return 0;
288+
return change;
284289
}
285290

286291
static int hwvad_get_enable(struct snd_kcontrol *kcontrol,

0 commit comments

Comments
 (0)