Skip to content

Commit 679a533

Browse files
Rob Clarkgregkh
authored andcommitted
drm/msm/a6xx: Fix HLSQ register dumping
[ Upstream commit c289a6d ] Fix the bitfield offset of HLSQ_READ_SEL state-type bitfield. Otherwise we are always reading TP state when we wanted SP or HLSQ state. Reported-by: Connor Abbott <cwabbott0@gmail.com> Suggested-by: Connor Abbott <cwabbott0@gmail.com> Fixes: 1707add ("drm/msm/a6xx: Add a6xx gpu state") Signed-off-by: Rob Clark <robin.clark@oss.qualcomm.com> Patchwork: https://patchwork.freedesktop.org/patch/714236/ Message-ID: <20260325184043.1259312-1-robin.clark@oss.qualcomm.com> Signed-off-by: Sasha Levin <sashal@kernel.org>
1 parent f101e4e commit 679a533

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -672,7 +672,7 @@ static void a6xx_get_crashdumper_hlsq_registers(struct msm_gpu *gpu,
672672
u64 out = dumper->iova + A6XX_CD_DATA_OFFSET;
673673
int i, regcount = 0;
674674

675-
in += CRASHDUMP_WRITE(in, REG_A6XX_HLSQ_DBG_READ_SEL, regs->val1);
675+
in += CRASHDUMP_WRITE(in, REG_A6XX_HLSQ_DBG_READ_SEL, (regs->val1 & 0xff) << 8);
676676

677677
for (i = 0; i < regs->count; i += 2) {
678678
u32 count = RANGE(regs->registers, i);

0 commit comments

Comments
 (0)