Skip to content

Commit 69a26b9

Browse files
Ethan Tidmoregregkh
authored andcommitted
drm/sun4i: Fix resource leaks
[ Upstream commit 127367a ] Three clocks are not being released in devm_regmap_init_mmio() error path. Add proper goto and set ret to the error code. Fixes: 8270249 ("drm/sun4i: backend: Create regmap after access is possible") Signed-off-by: Ethan Tidmore <ethantidmore06@gmail.com> Reviewed-by: Jernej Skrabec <jernej.skrabec@gmail.com> Link: https://patch.msgid.link/20260226163836.10335-1-ethantidmore06@gmail.com Signed-off-by: Chen-Yu Tsai <wens@kernel.org> Signed-off-by: Sasha Levin <sashal@kernel.org>
1 parent 3f3bc81 commit 69a26b9

1 file changed

Lines changed: 2 additions & 1 deletion

File tree

drivers/gpu/drm/sun4i/sun4i_backend.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -881,7 +881,8 @@ static int sun4i_backend_bind(struct device *dev, struct device *master,
881881
&sun4i_backend_regmap_config);
882882
if (IS_ERR(backend->engine.regs)) {
883883
dev_err(dev, "Couldn't create the backend regmap\n");
884-
return PTR_ERR(backend->engine.regs);
884+
ret = PTR_ERR(backend->engine.regs);
885+
goto err_disable_ram_clk;
885886
}
886887

887888
list_add_tail(&backend->engine.list, &drv->engine_list);

0 commit comments

Comments
 (0)