Skip to content

Commit 6adaa9f

Browse files
dhowellsgregkh
authored andcommitted
cifs: Fix oops due to uninitialised variable
[ Upstream commit 453a6d2 ] Fix smb3_init_transform_rq() to initialise buffer to NULL before calling netfs_alloc_folioq_buffer() as netfs assumes it can append to the buffer it is given. Setting it to NULL means it should start a fresh buffer, but the value is currently undefined. Fixes: a2906d3 ("cifs: Switch crypto buffer to use a folio_queue rather than an xarray") Signed-off-by: David Howells <dhowells@redhat.com> cc: Steve French <sfrench@samba.org> cc: Paulo Alcantara <pc@manguebit.org> cc: linux-cifs@vger.kernel.org cc: linux-fsdevel@vger.kernel.org Signed-off-by: Steve French <stfrench@microsoft.com> Signed-off-by: Sasha Levin <sashal@kernel.org>
1 parent 74605d6 commit 6adaa9f

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

fs/smb/client/smb2ops.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4496,7 +4496,7 @@ smb3_init_transform_rq(struct TCP_Server_Info *server, int num_rqst,
44964496
for (int i = 1; i < num_rqst; i++) {
44974497
struct smb_rqst *old = &old_rq[i - 1];
44984498
struct smb_rqst *new = &new_rq[i];
4499-
struct folio_queue *buffer;
4499+
struct folio_queue *buffer = NULL;
45004500
size_t size = iov_iter_count(&old->rq_iter);
45014501

45024502
orig_len += smb_rqst_len(server, old);

0 commit comments

Comments
 (0)