Skip to content

Commit 73461ff

Browse files
Vasily Gorbikgregkh
authored andcommitted
s390/debug: Reject zero-length input in debug_input_flush_fn()
commit e14622a upstream. debug_input_flush_fn() always copies one byte from the userspace buffer with copy_from_user() regardless of the supplied write length. A zero-length write therefore reads one byte beyond the caller's buffer. If the stale byte happens to be '-' or a digit the debug log is silently flushed. With an unmapped buffer the call returns -EFAULT. Reject zero-length writes before copying from userspace. Cc: stable@vger.kernel.org # v5.10+ Acked-by: Heiko Carstens <hca@linux.ibm.com> Signed-off-by: Vasily Gorbik <gor@linux.ibm.com> Signed-off-by: Alexander Gordeev <agordeev@linux.ibm.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent 1d57ab4 commit 73461ff

1 file changed

Lines changed: 5 additions & 0 deletions

File tree

arch/s390/kernel/debug.c

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1584,6 +1584,11 @@ static int debug_input_flush_fn(debug_info_t *id, struct debug_view *view,
15841584
char input_buf[1];
15851585
int rc = user_len;
15861586

1587+
if (!user_len) {
1588+
rc = -EINVAL;
1589+
goto out;
1590+
}
1591+
15871592
if (user_len > 0x10000)
15881593
user_len = 0x10000;
15891594
if (*offset != 0) {

0 commit comments

Comments
 (0)