pmdomain: imx: scu-pd: Fix device_node reference leak during ->probe()

outman119 · gregkh · commit 77d65c551393 · 2026-05-23T13:04:32.000+02:00
[ Upstream commit c8e9b6a ] When calling of_parse_phandle_with_args(), the caller is responsible to call of_node_put() to release the reference of device node. In imx_sc_pd_get_console_rsrc(), it does not release the reference. Fixes: 893cfb9 ("firmware: imx: scu-pd: do not power off console domain") Signed-off-by: Felix Gu <ustc.gu@gmail.com> Reviewed-by: Peng Fan <peng.fan@nxp.com> Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org> Signed-off-by: Sasha Levin <sashal@kernel.org>
diff --git a/drivers/pmdomain/imx/scu-pd.c b/drivers/pmdomain/imx/scu-pd.c
@@ -326,6 +326,7 @@ static void imx_sc_pd_get_console_rsrc(void)
 		return;
 
 	imx_con_rsrc = specs.args[0];
+	of_node_put(specs.np);
 }
 
 static int imx_sc_get_pd_power(struct device *dev, u32 rsrc)

Original file line number	Diff line number	Diff line change
`@@ -326,6 +326,7 @@ static void imx_sc_pd_get_console_rsrc(void)`
`326`	`326`	`return;`
`327`	`327`
`328`	`328`	`imx_con_rsrc = specs.args[0];`
	`329`	`+ of_node_put(specs.np);`
`329`	`330`	`}`
`330`	`331`
`331`	`332`	`static int imx_sc_get_pd_power(struct device *dev, u32 rsrc)`