Commit a086857
sched/rt: Skip group schedulable check with rt_group_sched=0
[ Upstream commit 8b016dc ]
The warning from the commit 87f1fb7 ("sched: Add RT_GROUP WARN
checks for non-root task_groups") is wrong -- it assumes that only
task_groups with rt_rq are traversed, however, the schedulability check
would iterate all task_groups even when rt_group_sched=0 is disabled at
boot time but some non-root task_groups exist.
The schedulability check is supposed to validate:
a) that children don't overcommit its parent,
b) no RT task group overcommits global RT limit.
but with rt_group_sched=0 there is no (non-trivial) hierarchy of RT groups,
therefore skip the validation altogether. Otherwise, writes to the
global sched_rt_runtime_us knob will be rejected with incorrect
validation error.
This fix is immaterial with CONFIG_RT_GROUP_SCHED=n.
Fixes: 87f1fb7 ("sched: Add RT_GROUP WARN checks for non-root task_groups")
Signed-off-by: Michal Koutný <mkoutny@suse.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Link: https://patch.msgid.link/20260323-sched-rert_groups-v3-1-1e7d5ed6b249@suse.com
Signed-off-by: Sasha Levin <sashal@kernel.org>1 parent 965fa82 commit a086857
1 file changed
Lines changed: 2 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2685 | 2685 | | |
2686 | 2686 | | |
2687 | 2687 | | |
2688 | | - | |
2689 | | - | |
2690 | | - | |
2691 | 2688 | | |
2692 | 2689 | | |
2693 | 2690 | | |
| |||
2831 | 2828 | | |
2832 | 2829 | | |
2833 | 2830 | | |
| 2831 | + | |
| 2832 | + | |
2834 | 2833 | | |
2835 | 2834 | | |
2836 | 2835 | | |
| |||
0 commit comments