Skip to content

Commit a263813

Browse files
valpackettgregkh
authored andcommitted
clk: qcom: gcc-sc8180x: Use retention for USB power domains
[ Upstream commit 25bc96f ] The USB subsystem does not expect to lose its state on suspend: xhci-hcd xhci-hcd.0.auto: xHC error in resume, USBSTS 0x401, Reinit usb usb1: root hub lost power or was reset (The reinitialization usually succeeds, but it does slow down resume.) To maintain state during suspend, the relevant GDSCs need to stay in retention mode, like they do on other similar SoCs. Change the mode to PWRSTS_RET_ON to fix. Fixes: 4433594 ("clk: qcom: gcc: Add global clock controller driver for SC8180x") Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com> Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com> Signed-off-by: Val Packett <val@packett.cool> Link: https://lore.kernel.org/r/20260312112321.370983-4-val@packett.cool Signed-off-by: Bjorn Andersson <andersson@kernel.org> Signed-off-by: Sasha Levin <sashal@kernel.org>
1 parent ed9ca2c commit a263813

1 file changed

Lines changed: 3 additions & 3 deletions

File tree

drivers/clk/qcom/gcc-sc8180x.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4172,7 +4172,7 @@ static struct gdsc usb30_sec_gdsc = {
41724172
.pd = {
41734173
.name = "usb30_sec_gdsc",
41744174
},
4175-
.pwrsts = PWRSTS_OFF_ON,
4175+
.pwrsts = PWRSTS_RET_ON,
41764176
.flags = POLL_CFG_GDSCR,
41774177
};
41784178

@@ -4190,7 +4190,7 @@ static struct gdsc usb30_prim_gdsc = {
41904190
.pd = {
41914191
.name = "usb30_prim_gdsc",
41924192
},
4193-
.pwrsts = PWRSTS_OFF_ON,
4193+
.pwrsts = PWRSTS_RET_ON,
41944194
.flags = POLL_CFG_GDSCR,
41954195
};
41964196

@@ -4262,7 +4262,7 @@ static struct gdsc usb30_mp_gdsc = {
42624262
.pd = {
42634263
.name = "usb30_mp_gdsc",
42644264
},
4265-
.pwrsts = PWRSTS_OFF_ON,
4265+
.pwrsts = PWRSTS_RET_ON,
42664266
.flags = POLL_CFG_GDSCR,
42674267
};
42684268

0 commit comments

Comments
 (0)