Skip to content

Commit a4515a3

Browse files
jhovoldgregkh
authored andcommitted
spi: mxic: fix controller deregistration
commit adbc595 upstream. Make sure to deregister the controller before disabling underlying resources like clocks (via runtime pm) during driver unbind. Fixes: b942d80 ("spi: Add MXIC controller driver") Cc: stable@vger.kernel.org # 5.0: cc53711 Cc: stable@vger.kernel.org # 5.0 Cc: Mason Yang <masonccyang@mxic.com.tw> Signed-off-by: Johan Hovold <johan@kernel.org> Link: https://patch.msgid.link/20260414134319.978196-6-johan@kernel.org Signed-off-by: Mark Brown <broonie@kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent ecd1417 commit a4515a3

1 file changed

Lines changed: 2 additions & 1 deletion

File tree

drivers/spi/spi-mxic.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -823,9 +823,10 @@ static void mxic_spi_remove(struct platform_device *pdev)
823823
struct spi_controller *host = platform_get_drvdata(pdev);
824824
struct mxic_spi *mxic = spi_controller_get_devdata(host);
825825

826+
spi_unregister_controller(host);
827+
826828
pm_runtime_disable(&pdev->dev);
827829
mxic_spi_mem_ecc_remove(mxic);
828-
spi_unregister_controller(host);
829830
}
830831

831832
static const struct of_device_id mxic_spi_of_ids[] = {

0 commit comments

Comments
 (0)