Skip to content

Commit a9a05e6

Browse files
braunergregkh
authored andcommitted
selftests/namespaces: remove unused utils.h include from listns_efault_test
[ Upstream commit cad3bf1 ] Remove the inclusion of ../filesystems/utils.h from listns_efault_test.c. The test doesn't use any symbols from that header. Including it alongside ../pidfd/pidfd.h causes a build failure because both headers define wait_for_pid() with conflicting linkage: ../filesystems/utils.h: extern int wait_for_pid(pid_t pid); ../pidfd/pidfd.h: static inline int wait_for_pid(pid_t pid) All symbols the test actually uses (create_child, read_nointr, write_nointr, sys_pidfd_send_signal) come from pidfd.h. Reported-by: Mark Brown <broonie@kernel.org> Link: https://lore.kernel.org/all/acPV19IY3Gna6Ira@sirena.org.uk Fixes: 07d7ad4 ("selftests/namespaces: test for efault") Signed-off-by: Christian Brauner <brauner@kernel.org> Signed-off-by: Sasha Levin <sashal@kernel.org>
1 parent 7900932 commit a9a05e6

1 file changed

Lines changed: 0 additions & 1 deletion

File tree

tools/testing/selftests/namespaces/listns_efault_test.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@
1919
#include <sys/wait.h>
2020
#include <unistd.h>
2121
#include "../kselftest_harness.h"
22-
#include "../filesystems/utils.h"
2322
#include "../pidfd/pidfd.h"
2423
#include "wrappers.h"
2524

0 commit comments

Comments
 (0)