Skip to content

Commit adfacfb

Browse files
mjbommargregkh
authored andcommitted
exfat: fix potential use-after-free in exfat_find_dir_entry()
commit 3f5f8ee upstream. In exfat_find_dir_entry(), the buffer_head obtained from exfat_get_dentry() is released with brelse(bh) before the fall-through TYPE_EXTEND branch reads the directory entry through ep (which points into bh->b_data): brelse(bh); if (entry_type == TYPE_EXTEND) { ... len = exfat_extract_uni_name(ep, entry_uniname); ... } After brelse() drops our reference, nothing guarantees that the underlying page backing bh->b_data remains valid for the subsequent exfat_extract_uni_name() read. This is the same pattern fixed in commit fc96152 ("exfat: Fix potential use after free in exfat_load_upcase_table()"). Move brelse(bh) so it runs after ep is no longer dereferenced on each branch. Confirmed on QEMU x86_64 with CONFIG_KASAN=y + CONFIG_DEBUG_PAGEALLOC=y + CONFIG_PAGE_POISONING=y on linux-next, using a crafted exFAT image (long filename with same-hash collisions forcing the TYPE_EXTEND path). With a debug-only invalidate_bdev() inserted between brelse(bh) and the ep read to make the stale-deref window deterministic, the unpatched kernel faults: BUG: KASAN: use-after-free in exfat_find_dir_entry+0x133b/0x15a0 BUG: unable to handle page fault for address: ffff88801a5fa0c2 Oops: 0000 [#1] SMP DEBUG_PAGEALLOC KASAN NOPTI RIP: 0010:exfat_find_dir_entry+0x1188/0x15a0 With this patch applied, the same instrumented harness completes cleanly under the same sanitizer stack. I have not reproduced a crash on an uninstrumented kernel under ordinary reclaim; the instrumented A/B establishes the lifetime violation and that the patch closes it, not an unaided triggerability claim. Fixes: ca06197 ("exfat: add directory operations") Cc: stable@vger.kernel.org Assisted-by: Claude:claude-opus-4-7 Signed-off-by: Michael Bommarito <michael.bommarito@gmail.com> Signed-off-by: Namjae Jeon <linkinjeon@kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent 6e61fc2 commit adfacfb

1 file changed

Lines changed: 3 additions & 1 deletion

File tree

fs/exfat/dir.c

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1081,12 +1081,12 @@ int exfat_find_dir_entry(struct super_block *sb, struct exfat_inode_info *ei,
10811081
continue;
10821082
}
10831083

1084-
brelse(bh);
10851084
if (entry_type == TYPE_EXTEND) {
10861085
unsigned short entry_uniname[16], unichar;
10871086

10881087
if (step != DIRENT_STEP_NAME ||
10891088
name_len >= MAX_NAME_LENGTH) {
1089+
brelse(bh);
10901090
step = DIRENT_STEP_FILE;
10911091
continue;
10921092
}
@@ -1097,6 +1097,7 @@ int exfat_find_dir_entry(struct super_block *sb, struct exfat_inode_info *ei,
10971097
uniname += EXFAT_FILE_NAME_LEN;
10981098

10991099
len = exfat_extract_uni_name(ep, entry_uniname);
1100+
brelse(bh);
11001101
name_len += len;
11011102

11021103
unichar = *(uniname+len);
@@ -1115,6 +1116,7 @@ int exfat_find_dir_entry(struct super_block *sb, struct exfat_inode_info *ei,
11151116
continue;
11161117
}
11171118

1119+
brelse(bh);
11181120
if (entry_type &
11191121
(TYPE_CRITICAL_SEC | TYPE_BENIGN_SEC)) {
11201122
if (step == DIRENT_STEP_SECD) {

0 commit comments

Comments
 (0)