Skip to content
/ linux Public

Commit b746a35

Browse files
tobluxgregkh
authored andcommitted
smb: client: Don't log plaintext credentials in cifs_set_cifscreds
commit 2f37dc4 upstream. When debug logging is enabled, cifs_set_cifscreds() logs the key payload and exposes the plaintext username and password. Remove the debug log to avoid exposing credentials. Fixes: 8a8798a ("cifs: fetch credentials out of keyring for non-krb5 auth multiuser mounts") Cc: stable@vger.kernel.org Acked-by: Paulo Alcantara (Red Hat) <pc@manguebit.org> Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev> Signed-off-by: Steve French <stfrench@microsoft.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent 5b3aa73 commit b746a35

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

fs/smb/client/connect.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2197,7 +2197,6 @@ cifs_set_cifscreds(struct smb3_fs_context *ctx, struct cifs_ses *ses)
21972197
/* find first : in payload */
21982198
payload = upayload->data;
21992199
delim = strnchr(payload, upayload->datalen, ':');
2200-
cifs_dbg(FYI, "payload=%s\n", payload);
22012200
if (!delim) {
22022201
cifs_dbg(FYI, "Unable to find ':' in payload (datalen=%d)\n",
22032202
upayload->datalen);

0 commit comments

Comments
 (0)