Skip to content

Commit be62c8b

Browse files
tiwaigregkh
authored andcommitted
ALSA: caiaq: Fix potentially leftover ep1_in_urb at error path
commit 0a7b522 upstream. The previous fix for handling the error from setup_card() missed that an internal URB cdev->ep1_in_urb might have been already submitted beforehand. In the normal case, this URB gets killed at the disconnection, but in the error path, we didn't do it, hence there can be a potential leak. Fix it in the error path for setup_card(), too. Fixes: 28abd22 ("ALSA: caiaq: Handle probe errors properly") Cc: <stable@vger.kernel.org> Link: https://patch.msgid.link/20260427123819.890185-1-tiwai@suse.de Signed-off-by: Takashi Iwai <tiwai@suse.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent 68532b0 commit be62c8b

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

sound/usb/caiaq/device.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -514,7 +514,7 @@ static int init_card(struct snd_usb_caiaqdev *cdev)
514514
card->private_free = card_free;
515515
err = setup_card(cdev);
516516
if (err < 0)
517-
return err;
517+
goto err_kill_urb;
518518

519519
return 0;
520520

0 commit comments

Comments
 (0)