Skip to content

Commit c0cc24c

Browse files
bvanasschegregkh
authored andcommitted
scsi: ufs: core: Remove WARN_ON_ONCE() call from ufshcd_uic_cmd_compl()
[ Upstream commit e5203d8 ] The UIC completion interrupt may be disabled while an UIC command is being processed. When the UIC completion interrupt is reenabled, an UIC interrupt is triggered and the WARN_ON_ONCE(!cmd) statement is hit. Hence this patch that removes this kernel warning. Fixes: fcd8b04 ("scsi: ufs: core: Make ufshcd_uic_cmd_compl() easier to analyze") Reviewed-by: Peter Wang <peter.wang@mediatek.com> Signed-off-by: Bart Van Assche <bvanassche@acm.org> Link: https://lore.kernel.org/r/20250815155842.472867-3-bvanassche@acm.org Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com> Signed-off-by: Sasha Levin <sashal@kernel.org>
1 parent 1a659c9 commit c0cc24c

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/ufs/core/ufshcd.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5533,7 +5533,7 @@ static irqreturn_t ufshcd_uic_cmd_compl(struct ufs_hba *hba, u32 intr_status)
55335533

55345534
guard(spinlock_irqsave)(hba->host->host_lock);
55355535
cmd = hba->active_uic_cmd;
5536-
if (WARN_ON_ONCE(!cmd))
5536+
if (!cmd)
55375537
goto unlock;
55385538

55395539
if (ufshcd_is_auto_hibern8_error(hba, intr_status))

0 commit comments

Comments
 (0)