Skip to content

Commit cc7716b

Browse files
dtorgregkh
authored andcommitted
platform/x86: barco-p50-gpio: normalize return value of gpio_get
[ Upstream commit 1c9d30d ] The GPIO get callback is expected to return 0 or 1 (or a negative error code). Ensure that the value returned by p50_gpio_get() is normalized to the [0, 1] range. Fixes: 86ef402 ("gpiolib: sanitize the return value of gpio_chip::get()") Reviewed-by: Linus Walleij <linusw@kernel.org> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> Reviewed-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com> Link: https://patch.msgid.link/20260318-barco-p50-gpio-set-v2-1-c0a4a6416163@gmail.com Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com> Signed-off-by: Sasha Levin <sashal@kernel.org>
1 parent e4a6666 commit cc7716b

1 file changed

Lines changed: 4 additions & 1 deletion

File tree

drivers/platform/x86/barco-p50-gpio.c

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -275,8 +275,11 @@ static int p50_gpio_get(struct gpio_chip *gc, unsigned int offset)
275275
mutex_lock(&p50->lock);
276276

277277
ret = p50_send_mbox_cmd(p50, P50_MBOX_CMD_READ_GPIO, gpio_params[offset], 0);
278-
if (ret == 0)
278+
if (ret == 0) {
279279
ret = p50_read_mbox_reg(p50, P50_MBOX_REG_DATA);
280+
if (ret >= 0)
281+
ret = !!ret;
282+
}
280283

281284
mutex_unlock(&p50->lock);
282285

0 commit comments

Comments
 (0)