Skip to content
/ linux Public

Commit d538b37

Browse files
LorenzoBianconigregkh
authored andcommitted
net: airoha: Remove airoha_dev_stop() in airoha_remove()
[ Upstream commit d4a533a ] Do not run airoha_dev_stop routine explicitly in airoha_remove() since ndo_stop() callback is already executed by unregister_netdev() in __dev_close_many routine if necessary and, doing so, we will end up causing an underflow in the qdma users atomic counters. Rely on networking subsystem to stop the device removing the airoha_eth module. Fixes: 23020f0 ("net: airoha: Introduce ethernet support for EN7581 SoC") Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org> Reviewed-by: Simon Horman <horms@kernel.org> Link: https://patch.msgid.link/20260313-airoha-remove-ndo_stop-remove-net-v2-1-67542c3ceeca@kernel.org Signed-off-by: Jakub Kicinski <kuba@kernel.org> Signed-off-by: Sasha Levin <sashal@kernel.org>
1 parent e9c66d3 commit d538b37

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

drivers/net/ethernet/airoha/airoha_eth.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3046,7 +3046,6 @@ static void airoha_remove(struct platform_device *pdev)
30463046
if (!port)
30473047
continue;
30483048

3049-
airoha_dev_stop(port->dev);
30503049
unregister_netdev(port->dev);
30513050
airoha_metadata_dst_free(port);
30523051
}

0 commit comments

Comments
 (0)