mctp: return -ENOPROTOOPT for unknown getsockopt options

aloktiwa · gregkh · commit dec6117dc4fa · 2025-09-09T19:02:27.000+02:00
[ Upstream commit a125c8f ] In mctp_getsockopt(), unrecognized options currently return -EINVAL. In contrast, mctp_setsockopt() returns -ENOPROTOOPT for unknown options. Update mctp_getsockopt() to also return -ENOPROTOOPT for unknown options. This aligns the behavior of getsockopt() and setsockopt(), and matches the standard kernel socket API convention for handling unsupported options. Fixes: 99ce45d ("mctp: Implement extended addressing") Signed-off-by: Alok Tiwari <alok.a.tiwari@oracle.com> Link: https://patch.msgid.link/20250902102059.1370008-1-alok.a.tiwari@oracle.com Signed-off-by: Jakub Kicinski <kuba@kernel.org> Signed-off-by: Sasha Levin <sashal@kernel.org>
diff --git a/net/mctp/af_mctp.c b/net/mctp/af_mctp.c
@@ -346,7 +346,7 @@ static int mctp_getsockopt(struct socket *sock, int level, int optname,
 		return 0;
 	}
 
-	return -EINVAL;
+	return -ENOPROTOOPT;
 }
 
 /* helpers for reading/writing the tag ioc, handling compatibility across the

Original file line number	Diff line number	Diff line change
`@@ -346,7 +346,7 @@ static int mctp_getsockopt(struct socket *sock, int level, int optname,`
`346`	`346`	`return 0;`
`347`	`347`	`}`
`348`	`348`
`349`		`- return -EINVAL;`
	`349`	`+ return -ENOPROTOOPT;`
`350`	`350`	`}`
`351`	`351`
`352`	`352`	`/* helpers for reading/writing the tag ioc, handling compatibility across the`