Skip to content

Commit e109404

Browse files
rfvirgilSasha Levin
authored andcommitted
ALSA: hda: cs35l56: Fix signedness error in cs35l56_hda_posture_put()
[ Upstream commit 003ce8c ] In cs35l56_hda_posture_put() assign ucontrol->value.integer.value[0] to a long instead of an unsigned long. ucontrol->value.integer.value[0] is a long. This fixes the sparse warning: sound/hda/codecs/side-codecs/cs35l56_hda.c:256:20: warning: unsigned value that used to be signed checked against zero? sound/hda/codecs/side-codecs/cs35l56_hda.c:252:29: signed value source Signed-off-by: Richard Fitzgerald <rf@opensource.cirrus.com> Fixes: 73cfbfa ("ALSA: hda/cs35l56: Add driver for Cirrus Logic CS35L56 amplifier") Link: https://patch.msgid.link/20260226111728.1700431-1-rf@opensource.cirrus.com Signed-off-by: Takashi Iwai <tiwai@suse.de> Signed-off-by: Sasha Levin <sashal@kernel.org>
1 parent baf4e79 commit e109404

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

sound/hda/codecs/side-codecs/cs35l56_hda.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -249,7 +249,7 @@ static int cs35l56_hda_posture_put(struct snd_kcontrol *kcontrol,
249249
struct snd_ctl_elem_value *ucontrol)
250250
{
251251
struct cs35l56_hda *cs35l56 = snd_kcontrol_chip(kcontrol);
252-
unsigned long pos = ucontrol->value.integer.value[0];
252+
long pos = ucontrol->value.integer.value[0];
253253
bool changed;
254254
int ret;
255255

0 commit comments

Comments
 (0)