dmaengine: mxs-dma: Fix missing return value from of_dma_controller_register()

nxpfrankli · gregkh · commit e532cd7fa1c9 · 2026-05-23T13:04:40.000+02:00
[ Upstream commit ab2bf6d ] Propagate the return value of of_dma_controller_register() in probe() instead of ignoring it. Fixes: a580b8c ("dmaengine: mxs-dma: add dma support for i.MX23/28") Signed-off-by: Frank Li <Frank.Li@nxp.com> Link: https://patch.msgid.link/20260225-mxsdma-module-v3-2-8f798b13baa6@nxp.com Signed-off-by: Vinod Koul <vkoul@kernel.org> Signed-off-by: Sasha Levin <sashal@kernel.org>
diff --git a/drivers/dma/mxs-dma.c b/drivers/dma/mxs-dma.c
@@ -824,6 +824,7 @@ static int mxs_dma_probe(struct platform_device *pdev)
 	if (ret) {
 		dev_err(mxs_dma->dma_device.dev,
 			"failed to register controller\n");
+		return ret;
 	}
 
 	dev_info(mxs_dma->dma_device.dev, "initialized\n");

Original file line number	Diff line number	Diff line change
`@@ -824,6 +824,7 @@ static int mxs_dma_probe(struct platform_device *pdev)`
`824`	`824`	`if (ret) {`
`825`	`825`	`dev_err(mxs_dma->dma_device.dev,`
`826`	`826`	`"failed to register controller\n");`
	`827`	`+ return ret;`
`827`	`828`	`}`
`828`	`829`
`829`	`830`	`dev_info(mxs_dma->dma_device.dev, "initialized\n");`