Skip to content
/ linux Public

Commit e9cc097

Browse files
carl-lee-amdSasha Levin
authored andcommitted
nfc: nxp-nci: remove interrupt trigger type
[ Upstream commit 57be33f ] For NXP NCI devices (e.g. PN7150), the interrupt is level-triggered and active high, not edge-triggered. Using IRQF_TRIGGER_RISING in the driver can cause interrupts to fail to trigger correctly. Remove IRQF_TRIGGER_RISING and rely on the IRQ trigger type configured via Device Tree. Signed-off-by: Carl Lee <carl.lee@amd.com> Link: https://patch.msgid.link/20260205-fc-nxp-nci-remove-interrupt-trigger-type-v2-1-79d2ed4a7e42@amd.com Signed-off-by: Jakub Kicinski <kuba@kernel.org> Signed-off-by: Sasha Levin <sashal@kernel.org>
1 parent 529eefd commit e9cc097

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/nfc/nxp-nci/i2c.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -305,7 +305,7 @@ static int nxp_nci_i2c_probe(struct i2c_client *client)
305305

306306
r = request_threaded_irq(client->irq, NULL,
307307
nxp_nci_i2c_irq_thread_fn,
308-
IRQF_TRIGGER_RISING | IRQF_ONESHOT,
308+
IRQF_ONESHOT,
309309
NXP_NCI_I2C_DRIVER_NAME, phy);
310310
if (r < 0)
311311
nfc_err(&client->dev, "Unable to register IRQ handler\n");

0 commit comments

Comments
 (0)