Skip to content
/ linux Public

Commit f18640b

Browse files
elkablogregkh
authored andcommitted
net: dsa: realtek: Fix LED group port bit for non-zero LED group
[ Upstream commit e8f0dc0 ] The rtl8366rb_led_group_port_mask() function always returns LED port bit in LED group 0; the switch statement returns the same thing in all non-default cases. This means that the driver does not currently support configuring LEDs in non-zero LED groups. Fix this. Fixes: 32d6170 ("net: dsa: realtek: add LED drivers for rtl8366rb") Signed-off-by: Marek Behún <kabel@kernel.org> Reviewed-by: Andrew Lunn <andrew@lunn.ch> Link: https://patch.msgid.link/20260311111237.29002-1-kabel@kernel.org Signed-off-by: Jakub Kicinski <kuba@kernel.org> Signed-off-by: Sasha Levin <sashal@kernel.org>
1 parent c78f01a commit f18640b

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

drivers/net/dsa/realtek/rtl8366rb-leds.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,11 +12,11 @@ static inline u32 rtl8366rb_led_group_port_mask(u8 led_group, u8 port)
1212
case 0:
1313
return FIELD_PREP(RTL8366RB_LED_0_X_CTRL_MASK, BIT(port));
1414
case 1:
15-
return FIELD_PREP(RTL8366RB_LED_0_X_CTRL_MASK, BIT(port));
15+
return FIELD_PREP(RTL8366RB_LED_X_1_CTRL_MASK, BIT(port));
1616
case 2:
17-
return FIELD_PREP(RTL8366RB_LED_0_X_CTRL_MASK, BIT(port));
17+
return FIELD_PREP(RTL8366RB_LED_2_X_CTRL_MASK, BIT(port));
1818
case 3:
19-
return FIELD_PREP(RTL8366RB_LED_0_X_CTRL_MASK, BIT(port));
19+
return FIELD_PREP(RTL8366RB_LED_X_3_CTRL_MASK, BIT(port));
2020
default:
2121
return 0;
2222
}

0 commit comments

Comments
 (0)