Skip to content
/ linux Public

Commit fa3635f

Browse files
broonieSasha Levin
authored andcommitted
mailbox: pcc: Remove spurious IRQF_ONESHOT usage
[ Upstream commit 6733270 ] The PCC code currently specifies IRQF_ONESHOT if the interrupt could potentially be shared but doesn't actually use request_threaded_irq() and the interrupt handler does not use IRQ_WAKE_THREAD so IRQF_ONESHOT is never relevant. Since commit aef30c8 ("genirq: Warn about using IRQF_ONESHOT without a threaded handler") specifying it has resulted in a WARN_ON(), fix this by removing IRQF_ONESHOT. Reported-by: Aishwarya TCV <Aishwarya.TCV@arm.com> Signed-off-by: Mark Brown <broonie@kernel.org> Reviewed-by: Sudeep Holla <sudeep.holla@arm.com> Signed-off-by: Jassi Brar <jassisinghbrar@gmail.com> Signed-off-by: Sasha Levin <sashal@kernel.org>
1 parent b74e552 commit fa3635f

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/mailbox/pcc.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -481,7 +481,7 @@ static int pcc_startup(struct mbox_chan *chan)
481481

482482
if (pchan->plat_irq > 0) {
483483
irqflags = pcc_chan_plat_irq_can_be_shared(pchan) ?
484-
IRQF_SHARED | IRQF_ONESHOT : 0;
484+
IRQF_SHARED : 0;
485485
rc = devm_request_irq(chan->mbox->dev, pchan->plat_irq, pcc_mbox_irq,
486486
irqflags, MBOX_IRQ_NAME, chan);
487487
if (unlikely(rc)) {

0 commit comments

Comments
 (0)