Optimize array patches when original array length is zero #970
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
@stephenmk since you have two PRs open for Patch, please bump the patch version and add an entry in the release notes on one of them, then I'll merge them so that it publishes the new version. |
Contributor
Author
|
@gregsdennis Added |
gregsdennis
reviewed
Dec 21, 2025
gregsdennis
reviewed
Dec 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request adds an optimization to
PatchExtensions.PatchForArray. When generating a patch in which an array from the original node contains 0 items and the corresponding target array contains N items, N > 0, then then the output patch should contain 1Replaceoperation instead of NAddoperations.Links
Resolves #964
Relates to #963 (also modifies this class method)
Checks