fix(cli): import fs-extra by gregswindle · Pull Request #11 · gregswindle/github-resource-converter

gregswindle · 2018-04-03T02:11:54Z

Description of change

Add fs-extra as a dependency.
Achieve passing tests with full coverage.
Update npm-outdated dependencies.

Associated issue(s)

Closes #10
Resolves #9
Resolves #8
Resolves #7
Resolves #6

Acceptance criteria/task completion

The acceptance criteria for all associated issues have been completed, tested, and validated.

PR check-list

✅ Please review and check the appropriate items.

1. Code standards compliance

ESLint passes.

2. Code quality

The quality gateways pass with an "A" grade.

Measure	Scores
`Complexity`
`Duplications`
`Issues`
`Maintainability`
`Reliability`
`Security`

3. Test coverage

The source code is 100% covered with passing specs.

** These tasks are not required to open a PR, and may be addresses while the PR is open.**

1. Mock @octokit/rest.js and dotenv 2. Refactor: rename github-resource-converter.js => base-resource-converter.js 3. Reports: send code coverage to Codacy 4. README.md: add contributing section 5. Add tests for baseResourceConverter #1

1. Add enum exportType 2. Add object fileExporter 3. Add test fixtures #1,#3,#4

#1,#4

See https://travis-ci.org/gregswindle/github-resource-converter/jobs/355791728#L2892 #1,#4

1. Appveyor didn't like the quotes for the eslintrc config path 2. Travis still cannot find the tests

#1,#4

1. .eslintrc: switch-case: 2 spaces 2. .travis: git.depth = 1 3. .travis: no-npm-dedupe 4. .travis: send codacy coverage with npm-script posttest:ci:coverage:codacy 5. .env.example: better explanations with new envvars 6. manifest: format and add npm-scripts 7. docs: fix markdown-magic config to modify CONTRIBUTING.md #1,#4

#1,#4

Attempt to run jest tests with full directory paths. #1,#4

Error parsing appveyor.yml: (Line: 37, Col: 5, Idx: 864) - (Line: 37, Col: 6, Idx: 865): While scanning for the next token, find character that cannot start any token #1,#4

I'm about to give up on Jest! 😠 #1,#4

#1,#4

Moved __(fixtures|mocks|tests)__ dirs to rootDir 🤞

#1,#4

Try using the 'jest-runner-eslint' test runner for Travis-CI and Appveyor. #1,#4

There's a reason why eslintrc is normally separated from gitignore. #1,#4

Put directories back under lib/ #1,#4

Correct typo for the coverage directory, too. #1,#4

Add the Greenkeeper badge. #1,#2,#3,#4

- Point to the correct pathname - Send coverage via an npm-script

Add exclusion patterns for tests, source, and CPD. #1,#2,#3,#4

#1,#2,#3,#4

Remove trailing whitespaces at ends of lines (L48). - Source: SonarCloud - Ref: L48 #1,#2,#3,#4

1. Add fs-extra as a dependency. 2. Achieve passing tests with full coverage. 3. Update npm-outdated dependencies. GH-10

gregswindle · 2018-04-03T02:18:37Z

SonarQube analysis reported 1 issue

1 minor

Watch the comments in this conversation to review them.

gregswindle · 2018-04-03T02:18:36Z

lib/cli-controller.js

+  const format = fileExporter.getExportFormat(cli.flags.dest)
+  const json = await getResources(cli, opts)
+  if (exportType.format.CSV === format) {
+    const data = await csvMediator.toCsv(json)


Immediately return this expression instead of assigning it to the temporary variable "data".

GH-10,GH-11

gregswindle · 2018-04-03T04:24:10Z

🎉 This PR is included in version 1.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

greenkeeper bot and others added 30 commits March 12, 2018 07:19

chore(package): update dependencies

baf31c9

docs(readme): add Greenkeeper badge

ce11e1f

test(cli): add tests and mocks

2d4aa4e

1. Mock @octokit/rest.js and dotenv 2. Refactor: rename github-resource-converter.js => base-resource-converter.js 3. Reports: send code coverage to Codacy 4. README.md: add contributing section 5. Add tests for baseResourceConverter #1

refactor(move): file export features

401a8fd

1. Add enum exportType 2. Add object fileExporter 3. Add test fixtures #1,#3,#4

test(cli): complete coverage

bbf46d7

#1,#4

build(jest): fix testMatch config

f9dae9e

#1,#4

ci(travis): fix 'no tests found' error

357212e

See https://travis-ci.org/gregswindle/github-resource-converter/jobs/355791728#L2892 #1,#4

ci(test): fix test issues

0da672c

1. Appveyor didn't like the quotes for the eslintrc config path 2. Travis still cannot find the tests

ci(tests): fix build tests

e487bd2

#1,#4

ci(tests): fix build tests

79363b3

#1,#4

ci(travis): try fixing jest

a7e4b24

#1,#4

ci(travis): more jest test fixes

25c52ca

#1,#4

ci(travis): more jest test fixes

9442412

#1,#4

ci(services): appveyor and travis

09958b8

Attempt to run jest tests with full directory paths. #1,#4

ci(appveyor): fix path issue

005a6bc

Error parsing appveyor.yml: (Line: 37, Col: 5, Idx: 864) - (Line: 37, Col: 6, Idx: 865): While scanning for the next token, find character that cannot start any token #1,#4

ci(jest): appveyor and travis

3757177

I'm about to give up on Jest! 😠 #1,#4

ci(jest): appveyor and travis

f574a8f

#1,#4

ci(jest): move dirs

793d983

Moved __(fixtures|mocks|tests)__ dirs to rootDir 🤞

ci(jest): add testPathPattern flag

6aac592

#1,#4

ci(jest): re-add testMatch

3a5641a

ci(jest): add package

c65f392

Try using the 'jest-runner-eslint' test runner for Travis-CI and Appveyor. #1,#4

ci(jest): add test runner

7ff478a

ci(jest): more fix attempts

2507444

fix(jest): add missing dir

7059e60

There's a reason why eslintrc is normally separated from gitignore. #1,#4

refactor(dirs): move directories

85186c5

Put directories back under lib/ #1,#4

docs(status): finish badges

9c61411

Correct typo for the coverage directory, too. #1,#4

ci(packages): automate dependency updates

cd140dd

Add the Greenkeeper badge. #1,#2,#3,#4

ci(tests): fix codacy-coverage

5968963

- Point to the correct pathname - Send coverage via an npm-script

style(lint): exlcude src analysis

d68c8ae

Add exclusion patterns for tests, source, and CPD. #1,#2,#3,#4

gregswindle added 4 commits March 20, 2018 22:30

build(repo): ignore SonarCloud artifacts

cba734e

#1,#2,#3,#4

style(code-smell): trailing whitespac

1aa9870

Remove trailing whitespaces at ends of lines (L48). - Source: SonarCloud - Ref: L48 #1,#2,#3,#4

test(coverage): add specs

18d06f8

fix(cli): import fs-extra

baaef50

1. Add fs-extra as a dependency. 2. Achieve passing tests with full coverage. 3. Update npm-outdated dependencies. GH-10

gregswindle self-assigned this Apr 3, 2018

gregswindle added the greenkeeper Automated dependency update label Apr 3, 2018

Merge branch 'master' into GH-10-fix-fs-extra-error

f05456a

gregswindle commented Apr 3, 2018

View reviewed changes

gregswindle added priority: critical Product unusable; address immediately status: accepted Defect confirmed or feature endorsed for work type: fix Defect repairs. ⇧ Bumps the PATCH semver. status: review needed type: defect Malfunctioning behavior type: refactor type: test labels Apr 3, 2018

chore(labels): add labels

b3956d3

GH-10,GH-11

gregswindle added this to the Fix CLI (v1.0.1) milestone Apr 3, 2018

gregswindle merged commit 3b988cf into master Apr 3, 2018

gregswindle deleted the GH-10-fix-fs-extra-error branch April 3, 2018 02:50

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(cli): import fs-extra#11

fix(cli): import fs-extra#11
gregswindle merged 36 commits intomasterfrom
GH-10-fix-fs-extra-error

gregswindle commented Apr 3, 2018 •

edited

Loading

Uh oh!

gregswindle commented Apr 3, 2018

Uh oh!

gregswindle Apr 3, 2018

Uh oh!

gregswindle commented Apr 3, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

gregswindle commented Apr 3, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description of change

Associated issue(s)

Acceptance criteria/task completion

PR check-list

1. Code standards compliance

2. Code quality

3. Test coverage

Uh oh!

gregswindle commented Apr 3, 2018

Uh oh!

gregswindle Apr 3, 2018

Choose a reason for hiding this comment

Uh oh!

gregswindle commented Apr 3, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

gregswindle commented Apr 3, 2018 •

edited

Loading