fix(save): implement "save" method for Node.js API#17
Merged
gregswindle merged 6 commits intomasterfrom Apr 4, 2018
Merged
Conversation
gregswindle
added
priority: high
Owner
Author
|
LGTM! 👍 |
gregswindle
added a commit
that referenced
this pull request
Apr 4, 2018
* fix(save): ensure module's save method works Add `save` method to baseResourceConveter, which invokes `fileExporter.save`. * docs(readme): update API section Enumerate all sections. * style(manifest): format * docs(readme): fix typo Replace `octokit` reference with `grc`. * fix(save): add save method to module GH-16, GH-17, GH-18
gregswindle
added a commit
that referenced
this pull request
Apr 4, 2018
* fix(save): ensure module's save method functions Added a #save method to baseResourceConveter, which invokes fileExporter.save. 😒 GH-16 * docs(readme): update API section Enumerate all sections. GH-16 * style(manifest): format GH-16 * docs(readme): fix typo Replace octokit ➡️ grc GH-16,GH-17 * fix(save): add save method to module GH-18 * build(changelog): add standard-version Use standard-version to generate a CHANGELOG, since semantic-release does not appear to have this feature. GH-18 * docs(changelog): add v1.0.0 to log GH-18
Owner
Author
|
🎉 This PR is included in version 1.0.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of change
savemethod tobaseResourceConveter, which invokesfileExporter.save. 😒.npmignoreand.npmrcfiles.ISSUE_TEMPLATE.md,defect-report.md, and automated query parameters for "Report a defect" and "Request a feature" buttons.Associated issue(s)
Resolves #16
Resolves #15
Acceptance criteria/task completion
PR check-list
1. Code standards compliance
ESLintpasses.2. Code quality
ComplexityDuplicationsIssuesMaintainabilityReliabilitySecurity3. Test coverage