Merged
Conversation
1. Mock @octokit/rest.js and dotenv 2. Refactor: rename github-resource-converter.js => base-resource-converter.js 3. Reports: send code coverage to Codacy 4. README.md: add contributing section 5. Add tests for baseResourceConverter #1
1. Appveyor didn't like the quotes for the eslintrc config path 2. Travis still cannot find the tests
1. .eslintrc: switch-case: 2 spaces 2. .travis: git.depth = 1 3. .travis: no-npm-dedupe 4. .travis: send codacy coverage with npm-script posttest:ci:coverage:codacy 5. .env.example: better explanations with new envvars 6. manifest: format and add npm-scripts 7. docs: fix markdown-magic config to modify CONTRIBUTING.md #1,#4
Moved __(fixtures|mocks|tests)__ dirs to rootDir 🤞
gregswindle
added a commit
that referenced
this pull request
Apr 3, 2018
gregswindle
added a commit
that referenced
this pull request
Apr 3, 2018
gregswindle
added a commit
that referenced
this pull request
Apr 3, 2018
gregswindle
added a commit
that referenced
this pull request
Apr 3, 2018
1. Update dependencies 2. Add Greenkeeper badge 3. Add tests and mocks 1. Mock @octokit/rest.js and dotenv 2. Refactor: rename github-resource-converter.js => base-resource-converter.js 3. Reports: send code coverage to Codacy 4. README.md: add contributing section 5. Add tests for baseResourceConverter 4. Refactor: move file export features 5. Add enum exportType 6. Add object fileExporter 7. Add test fixtures 8. Test cli: complete coverage 9. Build: jest fix testMatch config #1,#4 * ci(travis): fix 'no tests found' error See https://travis-ci.org/gregswindle/github-resource-converter/jobs/355791728#L2892 #1,#4 * ci(test): fix test issues 1. Appveyor didn't like the quotes for the eslintrc config path 2. Travis still cannot find the tests * ci(tests): fix build tests #1,#4 * ci(tests): fix build tests #1,#4 * ci(travis): try fixing jest #1,#4 * ci(travis): jest fixes and formatting 1. .eslintrc: switch-case: 2 spaces 2. .travis: git.depth = 1 3. .travis: no-npm-dedupe 4. .travis: send codacy coverage with npm-script posttest:ci:coverage:codacy 5. .env.example: better explanations with new envvars 6. manifest: format and add npm-scripts 7. docs: fix markdown-magic config to modify CONTRIBUTING.md #1,#4 * ci(travis): more jest test fixes #1,#4 * ci(travis): more jest test fixes #1,#4 * ci(services): appveyor and travis Attempt to run jest tests with full directory paths. #1,#4 * ci(appveyor): fix path issue Error parsing appveyor.yml: (Line: 37, Col: 5, Idx: 864) - (Line: 37, Col: 6, Idx: 865): While scanning for the next token, find character that cannot start any token #1,#4 * ci(jest): appveyor and travis I'm about to give up on Jest! 😠 #1,#4 * ci(jest): appveyor and travis #1,#4 * ci(jest): move dirs Moved __(fixtures|mocks|tests)__ dirs to rootDir 🤞 * ci(jest): add testPathPattern flag #1,#4 * ci(jest): re-add testMatch * ci(jest): add package Try using the 'jest-runner-eslint' test runner for Travis-CI and Appveyor. #1,#4 * ci(jest): add test runner * ci(jest): more fix attempts * fix(jest): add missing dir There's a reason why eslintrc is normally separated from gitignore. #1,#4 * refactor(dirs): move directories Put directories back under lib/ #1,#4 * docs(status): finish badges Correct typo for the coverage directory, too. #1,#4 * ci(tests): fix codacy-coverage - Point to the correct pathname - Send coverage via an npm-script * style(lint): exlcude src analysis Add exclusion patterns for tests, source, and CPD. #1,#2,#3,#4 * build(repo): ignore SonarCloud artifacts #1,#2,#3,#4 * style(code-smell): trailing whitespac Remove trailing whitespaces at ends of lines (L48). - Source: SonarCloud - Ref: L48 #1,#2,#3,#4 * test(coverage): add specs * fix(cli): import fs-extra 1. Add fs-extra as a dependency. 2. Achieve passing tests with full coverage. 3. Update npm-outdated dependencies. GH-10 * chore(labels): add labels GH-10,GH-11
Owner
Author
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of change
@octokit/rest.jsanddotenv.github-resource-converter.js=>base-resource-converter.jsREADME.md: add contributing sectionbaseResourceConverterandfileExporter.Associated issue(s)
Acceptance criteria/task completion
PR check-list
1. Code standards compliance
ESLintpasses.2. Code quality
ComplexityDuplicationsIssuesMaintainabilityReliabilitySecurity3. Test coverage