knockout Deleting widget issue (related with browser's resizing)

[ggenute]

Subject of the issue

Deleting widget issue (related with browser's reducing to display widgets in one column)

Your environment

• version of gridstack.js 1.0.0-dev
• Google Chrome Version 77.0.3865.90

Steps to reproduce

http://gridstackjs.com/demo/knockout.html http://gridstackjs.com/demo/knockout2.html

1. Resize the browser from displaying few gridstack columns to one column. Don't refresh the page.
2. Try to delete 3rd widget from the top, it deletes 1, 2, 3 widgets and doesn't removes 1st and 2nd widgets from the DOM.
3. Without page refresh come back to the full screen browser, the display of widgets is broken.

Expected behaviour

Deleting should work when the browser is resized from displaying few gridstack columns to one column.

Actual behaviour

When the browser is resized / reduced from displaying few gridstack columns to one column, deleting widgets doesn't work. After coming back to the full screen browser, the display of widgets is broken.

[radiolips]

Hey @ggenute . I was able to replicate the problem. When the original examples were written, they didn't take into account single-column-mode. I'll fix the demos when I have time, but for the time being, the issue is that when it attempts to remove the widget with self.widgets.remove(item);, it's comparing and item, which has single-column attributes, to an array of widgets with original specs.

[adumesny]

@ggenute are you running into this as a knockout app, or just found this in our demo ?

[ggenute]

@adumesny first I noticed in my app, and double checked how it works your demo. The same issue is in both.

[adumesny]

@ggenute this is fixed in current release. I completely re-wrote oneColumn mode (just setColumn(1) now so demos don't show any issues anymore.

Let me know if it doesn't work for you!

[ggenute]

Hi @adumesny. Updated to latest release. It works on my project as well. Thanks!