Authentication #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

jonenst merged 48 commits into master from authetication

Apr 3, 2020

Collaborator

ChamseddineBhd commented Mar 25, 2020

Please check if the PR fulfills these requirements (please use '[x]' to check the checkboxes, or submit the PR and then click the checkboxes)

The commit message follows our guidelines
Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem ? If so, link to this issue using '#XXX' and skip the rest

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

What is the current behavior? (You can also link to an open issue here)

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change or deprecate an API? If yes, check the following:

The Breaking Change or Deprecated label has been added
The migration guide has been updated in the github wiki (What changes might users need to make in their application due to this PR?)

Other information:

(if any of the questions/checkboxes don't apply, please delete them entirely)

ChamseddineBhd added 3 commits

March 25, 2020 15:48


          add authentication layer

15ab288

Signed-off-by: ChamseddineBhd <chamseddine.benhamed@ensi-uma.tn>


          remove unused dependency

2f89244

Signed-off-by: ChamseddineBhd <chamseddine.benhamed@ensi-uma.tn>


          cosmetic changes

ceaaeb7

Signed-off-by: ChamseddineBhd <chamseddine.benhamed@ensi-uma.tn>

ChamseddineBhd requested a review from jonenst

March 25, 2020 14:57

geofjamg changed the title ~~Authetication~~ Authentication

Member

geofjamg commented Mar 25, 2020

Don't forget license headers!

jonenst changed the title ~~Authentication~~ [WIP] Authentication

jonenst reviewed

View reviewed changes

public/signin-callback.html Outdated Show resolved Hide resolved

jonenst reviewed

View reviewed changes

public/silent-renew.html Outdated Show resolved Hide resolved

jonenst reviewed

View reviewed changes

src/components/top-bar.js Show resolved Hide resolved

jonenst reviewed

View reviewed changes

src/components/top-bar.js Outdated Show resolved Hide resolved

jonenst reviewed

View reviewed changes

src/services/AuthService.js Outdated Show resolved Hide resolved

jonenst reviewed

View reviewed changes

src/services/AuthService.js Outdated Show resolved Hide resolved

jonenst reviewed

View reviewed changes

src/services/AuthService.js Outdated Show resolved Hide resolved

jonenst reviewed

View reviewed changes

public/signin-callback.html Outdated Show resolved Hide resolved

jonenst reviewed

View reviewed changes

.env Outdated Show resolved Hide resolved

jonenst reviewed

View reviewed changes

.env.development Outdated Show resolved Hide resolved

jonenst requested changes

View reviewed changes

Contributor

jonenst left a comment

Please see my comments


          remove logs

0bb964f

Signed-off-by: ChamseddineBhd <chamseddine.benhamed@ensi-uma.tn>

ChamseddineBhd changed the title ~~[WIP] Authentication~~ Authentication [WIP]

ChamseddineBhd added 6 commits

March 25, 2020 23:28


          Merge branch 'master' into authetication

5fc16af


          delete callback html files, save user in store

804961f

Signed-off-by: ChamseddineBhd <chamseddine.benhamed@ensi-uma.tn>


          Merge branch 'authetication' of https://github.com/powsybl/powsybl-st…

043463a

…udy-app into authetication


          authentication not required in dev

fdd9791

Signed-off-by: ChamseddineBhd <chamseddine.benhamed@ensi-uma.tn>


          mock the user manager

7f4ebf6

Signed-off-by: ChamseddineBhd <chamseddine.benhamed@ensi-uma.tn>


          resolve conflicts with master

ad65768

Signed-off-by: ChamseddineBhd <chamseddine.benhamed@ensi-uma.tn>

ChamseddineBhd requested a review from jonenst

March 26, 2020 16:42


          resolve conflicts with master

db6a32a

Signed-off-by: ChamseddineBhd <chamseddine.benhamed@ensi-uma.tn>

jonenst reviewed

View reviewed changes

src/authentication/UserManagerMock.js Outdated Show resolved Hide resolved

jonenst reviewed

View reviewed changes

src/authentication/UserManagerMock.js Outdated Show resolved Hide resolved

ChamseddineBhd added 8 commits

March 31, 2020 16:47


          remove unused function call

9a054b6

Signed-off-by: ChamseddineBhd <chamseddine.benhamed@ensi-uma.tn>


          resolve conflict with master

7218b1f

Signed-off-by: ChamseddineBhd <chamseddine.benhamed@ensi-uma.tn>


          remove debug idp values

9e26374

Signed-off-by: ChamseddineBhd <chamseddine.benhamed@ensi-uma.tn>


          save previous route when logging in

993589e

Signed-off-by: ChamseddineBhd <chamseddine.benhamed@ensi-uma.tn>


          save previous query params

2e2952a

Signed-off-by: ChamseddineBhd <chamseddine.benhamed@ensi-uma.tn>


          cosmetic changes

ddf91cc

Signed-off-by: ChamseddineBhd <chamseddine.benhamed@ensi-uma.tn>


          cosmetic changes

c69c367

Signed-off-by: ChamseddineBhd <chamseddine.benhamed@ensi-uma.tn>


          remove silent redirect param

1d78ce4

Signed-off-by: ChamseddineBhd <chamseddine.benhamed@ensi-uma.tn>

geofjamg reviewed

View reviewed changes

src/utils/authentication/AuthService.js Show resolved Hide resolved

src/utils/authentication/UserManagerMock.js Show resolved Hide resolved

ChamseddineBhd added 12 commits

April 1, 2020 14:58


          add idp settings object

89714e7

Signed-off-by: ChamseddineBhd <chamseddine.benhamed@ensi-uma.tn>


          copyright

ce45795

Signed-off-by: ChamseddineBhd <chamseddine.benhamed@ensi-uma.tn>


          Merge branch 'master' into authetication

d014058


          add scope from idp settings

c6615bc

Signed-off-by: ChamseddineBhd <chamseddine.benhamed@ensi-uma.tn>


          remove client secret param

8aaf9ca

Signed-off-by: ChamseddineBhd <chamseddine.benhamed@ensi-uma.tn>


          update AuthService

a05235c

Signed-off-by: ChamseddineBhd <chamseddine.benhamed@ensi-uma.tn>


          add .env.development

d89465f

Signed-off-by: ChamseddineBhd <chamseddine.benhamed@ensi-uma.tn>


          empty idpSettings

5232d3d

Signed-off-by: ChamseddineBhd <chamseddine.benhamed@ensi-uma.tn>


          update SiginCallback

b8d8b27

Signed-off-by: ChamseddineBhd <chamseddine.benhamed@ensi-uma.tn>


          cosmetic changes

bd16ecb

Signed-off-by: ChamseddineBhd <chamseddine.benhamed@ensi-uma.tn>


          cosmetic changes

b2d1a32

Signed-off-by: ChamseddineBhd <chamseddine.benhamed@ensi-uma.tn>


          cosmetic changes

2e37c8a

Signed-off-by: ChamseddineBhd <chamseddine.benhamed@ensi-uma.tn>

geofjamg requested changes

View reviewed changes

Member

geofjamg left a comment

Menu does not close automatocally when going on parameters

ChamseddineBhd added 5 commits

April 3, 2020 13:13


          cosmetic changes

0085f16

Signed-off-by: ChamseddineBhd <chamseddine.benhamed@ensi-uma.tn>


          cosmetic changes'

f1ae026

Signed-off-by: ChamseddineBhd <chamseddine.benhamed@ensi-uma.tn>


          close menu after click

Signed-off-by: ChamseddineBhd <chamseddine.benhamed@ensi-uma.tn>


          change show parameters behaviour

a5f8473

Signed-off-by: ChamseddineBhd <chamseddine.benhamed@ensi-uma.tn>


          move authentication functions to AuthService

23fa250

Signed-off-by: ChamseddineBhd <chamseddine.benhamed@ensi-uma.tn>

jonenst approved these changes

View reviewed changes

jonenst merged commit ef62f0f into master

jonenst deleted the authetication branch

April 3, 2020 12:56

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet