Remove unneeded setting of precision that is causing errors in newer pandas versions #780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is in response to the error reported in #779. The cause is that newer versions of pandas (1.4.1 tested) have added another configuration variable containing the word "precision" making the statement
pd.set_option('precision', 3)no longer unique and causing an error. This statement wasn't needed either way so this PR removes it.During debugging of this issue, it was also discovered that the setting of 3 decimal places when writing the aggregate report file with
float_format='%.3f'in thepeptide_table.to_csvstatement no longer has the desired effect in pandas 1.4.1. This PR restructures how the result set is constructed so that the float_format works again.Closes #779