Assets created twice when importing using the --auto_incrementing tag

[BriskFrost]

I wanted to utilize the --auto_incrementing tag so assets imported from Jamf automatically generate the next appropriate asset tag number in Snipe-IT. When I did this, I ended up with a combination of the default behavior and the auto-incrementing behavior. Here is a sample of how the computers were imported:

It imported each asset twice, one with the default jamf-{id} asset tag, and the other with the --auto_incrementing asset tag. What's really interesting to me is that the auto-incrementing tags are only even. I have my theories as to why it's doing that, but I don't need to get into that.

I believe I included all the relevant details below, but if there are any other details I can provide, please let me know. Thanks!

The command I ran to initiate the sync:
python3 jamf2snipe -v --auto_incrementing --do_not_update_jamf -r -uns -c

My settings.config, minus confidential details (it's mostly just the default options):
manufacturer_id = 35
defaultStatus = 30
computer_model_category_id = 45
mobile_model_category_id = 25
# Not Required, uncomment to use
# computer_custom_fieldset_id = 3
# mobile_custom_fieldset_id = 4
# asset_tag = general serial_number # If not specified, defaults to jamf-{id} or jamf-m-{id}

[computers-api-mapping]
name = general name
_snipeit_mac_address_1 = general mac_address

[mobile_devices-api-mapping]
_snipeit_imei_4 = network imei
name = general name

[user-mapping] # The field from jamf that you want to search Snipe with
jamf_api_field = location username

Proof the auto-incrementing setting is correct in Snipe-IT:

Just about to report this myself. Seems like the problem may have been from #97 trying to fix support for the --auto-incrementing tag, which added more calls to create_snipe_asset when creating the payload. This can also break custom attribute syncing. I removed the extra lines and fixed the identation in my local copy, seems to work fine:

            # Create the payload
            if jamf_type == 'mobile_devices':
                logging.debug("Payload is being made for a mobile device")
                newasset = {'asset_tag': jamf_asset_tag, 'model_id': modelnumbers['{}'.format(jamf['general']['model_identifier'])], 'name': jamf['general']['name'], 'status_id': defaultStatus,'serial': jamf['general']['serial_number']}
            elif jamf_type == 'computers':
                logging.debug("Payload is being made for a computer")
                newasset = {'asset_tag': jamf_asset_tag,'model_id': modelnumbers['{}'.format(jamf['hardware']['model_identifier'])], 'name': jamf['general']['name'], 'status_id': defaultStatus,'serial': jamf['general']['serial_number']}
            else:
                for snipekey in config['{}-api-mapping'.format(jamf_type)]:
                    jamfsplit = config['{}-api-mapping'.format(jamf_type)][snipekey].split()
                    try:
                        for i, item in enumerate(jamfsplit):
                            try:
                                item = int(item)
                            except ValueError:
                                logging.debug('{} is not an integer'.format(item))
                            if i == 0:
                                jamf_value = jamf[item]
                            else:
                                if jamfsplit[0] == 'extension_attributes':
                                    for attribute in jamf_value:
                                        if attribute['id'] == item:
                                            jamf_value = attribute['value']
                                else:
                                    jamf_value = jamf_value[item]
                        newasset[snipekey] = jamf_value
                    except KeyError:
                        continue
            # Reset the payload without the asset_tag if auto_incrementing flag is set.
            if user_args.auto_incrementing:
                newasset.pop('asset_tag', None)
            new_snipe_asset = create_snipe_asset(newasset)
            logging.debug(new_snipe_asset)
            if new_snipe_asset[0] != "AssetCreated":
                continue
            if user_args.users or user_args.users_force or user_args.users_inverse:

[BriskFrost]

Thanks for the assist @mcarras8! In the build of jamf2snipe I'm using, editing the executable and replacing lines 812 through 847 with the code you provided fixed the issue!

[snipe]

Thanks folks! We’re flying today but will get this fix into the codebase as soon as we’ve landed (so hopefully tomorrow)

[ParadoxGuitarist]

Since it sounded like you were going to patch it, I went ahead and did a quick PR and bumped the version. #100

Should be patched in version 1.0.2 of the script.