Skip to content

makes test idempotent #199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 17, 2024
Merged

makes test idempotent #199

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8a56817
makes test idempotent
Apr 2, 2024
a82e11e
adding comment
Apr 15, 2024
9c00c6a
Merge branch 'main' into make_action_tests_idempotent
Apr 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions test/unit/test_actions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@


def test_create_action(gl: ExperimentalApi):
# We first clear out any rules in case the account has any left over from a previous test
gl.delete_all_rules()
Copy link
Contributor

@blaise-muhirwa blaise-muhirwa Apr 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a comment here mentioning that we are deleting rules first just so previous runs don't affect results from the current test run?

name = f"Test {datetime.utcnow()}"
det = gl.get_or_create_detector(name, "test_query")
rule = gl.create_rule(det, "test_rule", "EMAIL", "test@example.com")
Expand Down