Rename groundlight_openapi_client #201
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjvogelsong
commented
Apr 4, 2024
| -g python \ | ||
| -o ./generated | ||
| -o ./generated \ | ||
| --additional-properties=packageName=groundlight_openapi_client |
Contributor
Author
There was a problem hiding this comment.
This is the main change. Everything else is either auto-generated or CTRL-F changing references from openapi_client to groundlight_openapi_client
brandon-wada
approved these changes
Apr 4, 2024
Collaborator
brandon-wada
left a comment
brandon-wada
left a comment
There was a problem hiding this comment.
Nice, this is has to be the record for number of files changed. I love autogenerated code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OpenAPI generator (annoyingly) uses
openapi_clientas a top-level import, which forces us to exposeopenapi_clientas a top-level package when it's pip installed. This causes issues if a consumer also usesopenapi_client.So, as a workaround, we can rename
openapi_clienttogroundlight_openapi_clientto prevent name clashes. There might be a better way to do this, but we're not sure how yet.