Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the CLI’s install-method detection (used by grounds version --check update hints) to better recognize Homebrew Cask installations and recommend an appropriate brew upgrade command.
Changes:
- Added separate update-command constants for Homebrew formula vs Homebrew cask upgrades.
- Extended Homebrew detection logic to identify cask installs and return a cask-specific upgrade command.
- Added unit tests for Homebrew cask install paths on Linux.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| internal/version/install_method.go | Adds Homebrew cask detection and separates formula vs cask upgrade commands. |
| internal/version/install_method_test.go | Adds test cases covering Linux Homebrew cask install paths. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
lusu007
force-pushed
the
codex/fix-homebrew-cask-install-method
branch
from
d2cd0e4 to
efcc0d8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
Type of Change
Related Issues
Testing
Checklist