Skip to content

Conversation

@zxfishhack
Copy link
Contributor

@zxfishhack zxfishhack commented Jan 16, 2019

fix #120 #166 , zap will not cleanup duplicate field but logrus will. so can't call ctxzap.TagsToFields() twice.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@codecov-io
Copy link

codecov-io commented Jan 16, 2019

Codecov Report

Merging #187 into master will decrease coverage by 0.29%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #187     +/-   ##
=========================================
- Coverage    73.2%   72.91%   -0.3%     
=========================================
  Files          36       36             
  Lines        1340     1340             
=========================================
- Hits          981      977      -4     
- Misses        310      314      +4     
  Partials       49       49
Impacted Files Coverage Δ
logging/zap/server_interceptors.go 100% <100%> (ø) ⬆️
retry/retry.go 76.11% <0%> (-2.23%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4832df0...b86604e. Read the comment docs.

@googlebot
Copy link

CLAs look good, thanks!

@Crevil
Copy link

Crevil commented Sep 24, 2019

Anything blocking this PR for merge?

@johanbrandhorst johanbrandhorst merged commit a255b85 into grpc-ecosystem:master Sep 24, 2019
@johanbrandhorst
Copy link
Collaborator

Thanks for the reminder :).

@Crevil
Copy link

Crevil commented Sep 24, 2019

Sweet. Thanks for merging. :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Duplicate peer.address in zap logger output

5 participants