Reorganize code for 0.2.0 release. #41
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Split the large client/server.dart files into smaller pieces. This is in preparation for splitting the HTTP/2 dependencies into a separate file and make it easier to implement other transports.
mravn-google
approved these changes
Dec 14, 2017
lib/src/client/call.dart
Outdated
| import '../shared/status.dart'; | ||
| import '../shared/streams.dart'; | ||
|
|
||
| import 'client.dart'; |
There was a problem hiding this comment.
This dependency is part of a cycle. You may be able to break it by moving ClientMethod here or to its own client/method.dart file.
lib/src/client/channel.dart
Outdated
| import '../shared/status.dart'; | ||
|
|
||
| import 'call.dart'; | ||
| import 'client.dart'; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly just moving code around. Actual changes: