Skip to content

Conversation

@devoncarew
Copy link
Contributor

@github-actions
Copy link

PR Health

Breaking changes ⚠️
Package Change Current Version New Version Needed Version Looking good?
grpc Breaking 4.0.1 4.0.2-wip 5.0.0
Got "4.0.2-wip" expected >= "5.0.0" (breaking changes)
⚠️

This check can be disabled by tagging the PR with skip-breaking-check.

Changelog Entry
Package Changed Files
package:grpc example/grpc-web/pubspec.yaml
lib/src/shared/status.dart

Changes to files need to be accounted for in their respective changelogs.

This check can be disabled by tagging the PR with skip-changelog-check.

Coverage ✔️
File Coverage
lib/src/shared/status.dart 💚 59 %

This check for test coverage is informational (issues shown here will not fail the PR).

API leaks ⚠️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbols
grpc Any
$1.Duration

This check can be disabled by tagging the PR with skip-leaking-check.

@devoncarew
Copy link
Contributor Author

Hmm, it looks like there are already some in-flight PRs to address #756 (https://github.com/grpc/grpc-dart/pulls); we should probably prefer to land some combination of them.

@aran
Copy link
Contributor

aran commented Feb 20, 2025

I think this is covered by #748 as well but doesn't really matter which one lands. Please let me know if you'd like me to close #748, happy to do that.

@mosuem
Copy link
Contributor

mosuem commented Feb 21, 2025

Closing in favor of #748

@mosuem mosuem closed this Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants