README: document the no-deps design constraints #345
Conversation
See this issue for context: grpc#341 (comment)
There was a problem hiding this comment.
"external" is still murky for users. For example, grpc package depends on "golang.org/x/net/context". We need to better define "external".
There was a problem hiding this comment.
Well, I can't define external because I don't know the rules. Clearly we should document the rules so we can point to the rules when people open PRs and hopefully avoid duplicate work.
There was a problem hiding this comment.
my suggestion:
The google.golang.org/grpc Go package must not depend on any non-standard or non-official external Go libraries.
There was a problem hiding this comment.
define official. I don't know what official means.
There was a problem hiding this comment.
I meant https://github.com/golang.
There was a problem hiding this comment.
THat is a great way to put it.
On Mon, Sep 21, 2015 at 10:53 AM Qi Zhao notifications@github.com wrote:
In README.md
#345 (comment):@@ -18,6 +18,11 @@ Prerequisites
This requires Go 1.4 or above.
+Design Constraints
+------------------
+
+Thegoogle.golang.org/grpchttp://google.golang.org/grpc Go package must not depend on any external Go libraries. This is to simplify use when vendored into other Go projects.I meant https://github.com/golang.
—
Reply to this email directly or view it on GitHub
https://github.com/grpc/grpc-go/pull/345/files#r40002547.
|
replaced by #364 |
2 participants
See this issue for context:
#341 (comment)