Mismatch in naming with bazel maven jars

[pgr0ss]

I am trying to use grpc-java in an existing project which uses bazel, java, and a bunch of jars from maven. I added this to my WORKSPACE:

load("@grpc_java//:repositories.bzl", "grpc_java_repositories")

grpc_java_repositories(
  omit_com_google_guava=True,
)

The problem is that I use the migration-tooling project to add maven jars, and its naming for external jars does not match yours. For example, you call it @com_google_guava[1] but that project uses @com_google_guava_guava[2]. So if I try to use the omits, I get:

no such package '@com_google_guava//jar': The repository could not be resolved

And if I remove the omits, my project references two different versions of guava and I get runtime errors (since this project uses guava 19 and I want 21).

Is it possible to switch the naming of external maven jars to match bazel's tooling?

Please answer these questions before submitting your issue.

What version of gRPC are you using?

1.5.0

What JVM are you using (java -version)?

% java -version
java version "1.8.0_144"
Java(TM) SE Runtime Environment (build 1.8.0_144-b01)
Java HotSpot(TM) 64-Bit Server VM (build 25.144-b01, mixed mode)

[1] https://github.com/grpc/grpc-java/blob/master/repositories.bzl#L113
[2]

% bazel run //generate_workspace -- --output_dir /tmp --artifact=com.google.guava:guava:21.0
...
Wrote /tmp/generate_workspace.bzl

% cat /tmp/generate_workspace.bzl 
# The following dependencies were calculated from:
#
# generate_workspace --output_dir /tmp --artifact=com.google.guava:guava:21.0


def generated_maven_jars():
  native.maven_jar(
      name = "com_google_guava_guava",
      artifact = "com.google.guava:guava:21.0",
  )




def generated_java_libraries():
  native.java_library(
      name = "com_google_guava_guava",
      visibility = ["//visibility:public"],
      exports = ["@com_google_guava_guava//jar"],
  )

[ejona86]

Yeah, we should fix this to follow the convention. I notice multiple others that also aren't following the maven_jar naming convention.

If you send a PR I can easily review it. If not I'll try to find some time to fix it up.

[pgr0ss]

I attempted to make this change, but I'm running into some stuff I don't understand. For example, I tried to change the protobuf dependency with this diff:

% git diff
diff --git a/examples/BUILD.bazel b/examples/BUILD.bazel
index b4fe3e2..9587d1e 100644
--- a/examples/BUILD.bazel
+++ b/examples/BUILD.bazel
@@ -49,8 +49,8 @@ java_library(
         "@com_google_api_grpc_proto_google_common_protos//jar",
         "@com_google_code_findbugs_jsr305//jar",
         "@com_google_guava//jar",
-        "@com_google_protobuf_java//:protobuf_java",
-        "@com_google_protobuf_java//:protobuf_java_util",
+        "@com_google_protobuf_protobuf_java//:protobuf_java",
+        "@com_google_protobuf_protobuf_java//:protobuf_java_util",
         "@grpc_java//core",
         "@grpc_java//protobuf",
         "@grpc_java//stub",
diff --git a/java_grpc_library.bzl b/java_grpc_library.bzl
index 008457e..8a33fea 100644
--- a/java_grpc_library.bzl
+++ b/java_grpc_library.bzl
@@ -113,10 +113,10 @@ def java_grpc_library(name, srcs, deps, flavor=None,
       "@com_google_guava//jar",
   ]
   if flavor == "normal":
-    added_deps += ["@com_google_protobuf_java//:protobuf_java"]
+    added_deps += ["@com_google_protobuf_protobuf_java//:protobuf_java"]
   elif flavor == "lite":
     # TODO: This is currently blocked on https://github.com/google/protobuf/issues/2762
-    added_deps += ["@com_google_protobuf_java_lite//:protobuf_java_lite"]
+    added_deps += ["@com_google_protobuf_protobuf_java_lite//:protobuf_java_lite"]
   else:
     fail("Unknown flavor type", "flavor")
 
diff --git a/protobuf-lite/BUILD.bazel b/protobuf-lite/BUILD.bazel
index 74939c2..f705c0b 100644
--- a/protobuf-lite/BUILD.bazel
+++ b/protobuf-lite/BUILD.bazel
@@ -10,6 +10,6 @@ java_library(
         "//core:internal",
         "@com_google_code_findbugs_jsr305//jar",
         "@com_google_guava//jar",
-        "@com_google_protobuf_java//:protobuf_java",
+        "@com_google_protobuf_protobuf_java//:protobuf_java",
     ],
 )
diff --git a/protobuf/BUILD.bazel b/protobuf/BUILD.bazel
index 58521b4..269fffa 100644
--- a/protobuf/BUILD.bazel
+++ b/protobuf/BUILD.bazel
@@ -10,7 +10,7 @@ java_library(
         "@com_google_api_grpc_proto_google_common_protos//jar",
         "@com_google_code_findbugs_jsr305//jar",
         "@com_google_guava//jar",
-        "@com_google_protobuf_java//:protobuf_java",
-        "@com_google_protobuf_java//:protobuf_java_util",
+        "@com_google_protobuf_protobuf_java//:protobuf_java",
+        "@com_google_protobuf_protobuf_java//:protobuf_java_util",
     ],
 )
diff --git a/repositories.bzl b/repositories.bzl
index 05b2c97..5319564 100644
--- a/repositories.bzl
+++ b/repositories.bzl
@@ -134,10 +134,10 @@ def com_google_protobuf():
   )
 
 def com_google_protobuf_java():
-  # java_proto_library rules implicitly depend on @com_google_protobuf_java//:java_toolchain,
+  # java_proto_library rules implicitly depend on @com_google_protobuf_protobuf_java//:java_toolchain,
   # which is the Java proto runtime (base classes and common utilities).
   native.http_archive(
-      name = "com_google_protobuf_java",
+      name = "com_google_protobuf_protobuf_java",
       sha256 = "df77b0e60afcd3d90b2654cd305e61ae8ae2e2281b4d6540c7093da4c4245d75",
       strip_prefix = "protobuf-3.3.1",
       urls = ["https://github.com/google/protobuf/archive/v3.3.1.zip"],

But now I get build errors related to proto_library, and I can't find the definition:

% bazel build //...
ERROR: /home/admin/grpc-java/examples/BUILD.bazel:19:1: every rule of type proto_library implicitly depends upon the target '@com_google_protobuf_java//:java_toolchain', but this target could not be found because of: no such package '@com_google_protobuf_java//': The repository could not be resolved.
ERROR: Analysis of target '//examples:examples' failed; build aborted.
INFO: Elapsed time: 0.957s

Where is that rule defined? And does it also hardcode the value I'm trying to change?

[dapengzhang0]

@pgr0ss is your bazel version 0.4.5 or higher?

[pgr0ss]

% bazel version
.................
Build label: 0.5.2
Build target: bazel-out/local-fastbuild/bin/src/main/java/com/google/devtools/build/lib/bazel/BazelServer_deploy.jar
Build time: Tue Jun 27 13:27:03 2017 (1498570023)
Build timestamp: 1498570023
Build timestamp as int: 1498570023

[ejona86]

@pgr0ss, feel free to leave the protobuf unchanged; fixing the others would still be beneficial.

@com_google_protobuf_java is required by Bazel itself. But I can't find anything in the rule documentation about it. I guess the different naming for com_google_protobuf_java is okay since it should eventually be a Bazel reference; not a Maven reference.

[pgr0ss]

@ejona86 Done: #3338