-
Notifications
You must be signed in to change notification settings - Fork 3.9k
Closed
Milestone
Description
Census has an open-source requestz implementation that can show traces of live, sampled and error RPCs. In order to sample RPCs, gRPC needs to call SampledSpanStore.registerSpanNamesForCollection() with any known method name. This is fairly expensive, thus should not be called on a per-RPC basis. A few options:
- In a static initializer in the generated code. If we don't want to call Census directly from the generated code, maybe call Census code in a helper function in
ClientCallsandServerCallswhich is called from generated code. - In
MethodDescriptorconstructor. This will be called once per method, which might slow start-up speed. This would also all custom-created methods to be registered, @bogdandrutu is this desirable, or do you only expect generated methods to be registered?
Option 1 sounds like a better option. @ejona86 WDYT?
Metadata
Metadata
Assignees
Labels
No labels